Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk/go/v2): support sdk go v2 in generator #3880

Merged
merged 5 commits into from
Feb 6, 2025
Merged

feat(sdk/go/v2): support sdk go v2 in generator #3880

merged 5 commits into from
Feb 6, 2025

Conversation

GeorgeMac
Copy link
Member

Opening this up as a WIP for now. It is currently queued up behind my other PR: #3879

This updates the protoco-gen-go-flipt-sdk generator so that we can support a v2 SDK.
This means:

  • a custom import path
  • invoking it from the buf gen yaml
  • moving v1 specific auth methods (OG k8s) out of the generator and hard-coding in the v1 SDK

@markphelps markphelps added the v2 For consideration for v2 of Flipt label Feb 5, 2025
@GeorgeMac GeorgeMac marked this pull request as ready for review February 6, 2025 13:54
@GeorgeMac GeorgeMac requested a review from a team as a code owner February 6, 2025 13:54
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 6, 2025
@GeorgeMac GeorgeMac merged commit fc3b8c7 into v2 Feb 6, 2025
4 of 29 checks passed
@GeorgeMac GeorgeMac deleted the gm/v2-sdk-go branch February 6, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XXL This PR changes 1000+ lines, ignoring generated files. v2 For consideration for v2 of Flipt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants