chore: V2 config rework pt1 #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: Mark Phelps <[email protected]>
dosubot
bot
added
the
size:XXL
GeorgeMac
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started to rework the configuration for v2 to remove un-needed pieces (for now) but eventually got side tracked by removing the legacy evaluation API as it will no longer be supported in v2.
This PR is a mix of:
Since this PR is already quite large, I will do the environments/storage configuration changes in another PR
Robot Words
This pull request includes several changes focused on removing legacy code, simplifying configurations, and cleaning up documentation. The most important changes include the removal of legacy evaluation tests, updates to the migration command, and the deletion of outdated audit examples.
Removal of Legacy Code:
build/testing/integration/api/api.go: Removed legacy evaluation and compatibility tests to streamline the testing process. [1] [2]build/testing/integration/readonly/readonly_test.go: Removed legacy evaluation and batch evaluation tests.Updates to Migration Command:
cmd/flipt/migrate.go: Updated migration command to remove thedatabaseparameter and use theanalyticspackage directly. [1] [2] [3]Cleanup and Documentation:
examples/audit/README.md,examples/audit/kafka/README.md,examples/audit/kafka/docker-compose.yml: Removed outdated audit examples and related documentation. [1] [2] [3]build/testing/redpanda.go: Deleted theredpandaTLSServicefunction and associated configuration templates.config/flipt.schema.cue: Simplified the schema by removing unnecessary comments and fields. [1] [2] [3] [4]Minor Fixes:
build/testing/integration/api/api.go: Corrected a typo in a comment.build/testing/test.go: Removed Kafka unit testing setup.examples/audit/log/.gitignore: Removed the loki directory from the gitignore file.