feat(rpc): initial prototype for the v2 environments API #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markphelps
reviewed
Jan 23, 2025
| @@ -0,0 +1,122 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package environments; | |||
There was a problem hiding this comment.
do these need to be globally unique? i don't remember. ie flipt.environments?
There was a problem hiding this comment.
It doesn't in this world where I replicated what we do in flipt cloud.
Here rpc/v2/environments is its own root package.
It lives alongside the legacy v1 rpc/flipt.
dosubot
bot
added
the
size:XXL
markphelps
added a commit
that referenced
this pull request
Jan 27, 2025
…nv-config * 'env-config' of https://github.com/flipt-io/flipt: feat(rpc): initial prototype for the v2 environments API (#3834)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports #3832
This is an initial draft of a v2 API based on proposal (2) in this issue comment: #3832 (comment)
I will update with more details as I make progress removing dead code and rewiring new service definitions.