fix: update attachment messaging and size to allow 1mb #3595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Martyn <[email protected]>
MMartyn
force-pushed
the
fix/attachment-size
branch
from
a69078a to
0a86e79
Compare
|
Hey Matt. Thank you for your first contribution! |
markphelps
approved these changes
Nov 5, 2024
|
Thank you @MMartyn !! @all-contributors please add @MMartyn for code |
|
I've put up a pull request to add @MMartyn! 🎉 |
|
Thanks all 👍 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3595 +/- ##
=======================================
Coverage 64.14% 64.14%
=======================================
Files 169 169
Lines 16956 16956
=======================================
Hits 10876 10876
Misses 5400 5400
Partials 680 680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
markphelps
added a commit
that referenced
this pull request
Nov 5, 2024
erka
added a commit
that referenced
this pull request
Dec 10, 2024
Currently Flipt with authz requires user to have read access to default namespace in order to list the namespaces. This edge case ninja'd its way into the code like a shadow in the night, but it’s time for this stealthy PR troublemaker to find another codebase to haunt! Side effect 1: the deps has been updated and the code should be regenerated. Side effect 2: the tests are broken with PR #3595 in RPC and they are not run in CI. Signed-off-by: Roman Dmytrenko <[email protected]>
erka
added a commit
that referenced
this pull request
Dec 10, 2024
) Currently Flipt with authz requires user to have read access to default namespace in order to list the namespaces. This edge case ninja'd its way into the code like a shadow in the night, but it’s time for this stealthy PR troublemaker to find another codebase to haunt! Side effect 1: the deps has been updated and the code should be regenerated. Side effect 2: the tests are broken with PR #3595 in RPC and they are not run in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3594