Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Cloud serve #3041

Merged
merged 11 commits into from
May 6, 2024
Merged

feat: Cloud serve #3041

merged 11 commits into from
May 6, 2024

Conversation

markphelps
Copy link
Collaborator

@markphelps markphelps commented May 2, 2024

Fixes: FLI-980
Fixes: FLI-985

  • Adds flipt cloud serve command to automatically create temp instance in cloud, and setup tunnel automagically
  • Adds flipt cloud logout command

TODO

  • Tests
  • Check for expiration of auth token
  • Figure out how to check for existing instance

@markphelps markphelps marked this pull request as ready for review May 3, 2024 18:12
@markphelps markphelps requested a review from a team as a code owner May 3, 2024 18:12
@markphelps markphelps requested a review from GeorgeMac May 5, 2024 15:36
Copy link
Member

@GeorgeMac GeorgeMac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely now 👍
I have a PR in the works for reverst to move backoff in there. But we can bump the client version and remove that from here in a later PR.

@markphelps markphelps merged commit 6864d48 into cloud May 6, 2024
28 checks passed
@markphelps markphelps deleted the cloud-serve branch May 6, 2024 17:08
markphelps added a commit that referenced this pull request May 13, 2024
* feat: cloud config

chore: add config tests and auth

chore: add api key for tunnel connection

chore: config changes

chore: fix server close

* chore: mod tidy

* chore: remove unused config options for now

* feat(cmd/flipt): wire in flipt client listener

* chore: revert rm config

* feat: Cloud Authn (#3038)

* feat: start impl of cloud link

* chore: change token param to id_token

Signed-off-by: Mark Phelps <[email protected]>

* chore: start http server

* chore: PR updates

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix write html

Signed-off-by: Mark Phelps <[email protected]>

* chore: rm uneeded struct

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix cue schema

Signed-off-by: Mark Phelps <[email protected]>

* chore: respond to PR feedback, fix schema

* chore: try to fix cli ITs

* chore: set min TLS version

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>

* feat: Cloud serve (#3041)

* feat: start cloud serve command

* chore: start flipt with new config

* feat: validate JWT; retry reverst connections; check for expiry and existing instance

* chore: handle error response

* chore: add spinner

* Revert "chore: add spinner"

This reverts commit bb35379.

* chore: dont make org/instance/api key required for now

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix tests

Signed-off-by: Mark Phelps <[email protected]>

* feat: impl cloud auth (#3045)

* feat: impl cloud auth

* chore: PR feedback

Signed-off-by: Mark Phelps <[email protected]>

* chore: fix tests

---------

Signed-off-by: Mark Phelps <[email protected]>

* chore: use backoff from reverst

* chore: fix build

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>

* fix: rm port from cloud host if there (#3060)

Signed-off-by: Mark Phelps <[email protected]>

* feat: update reverst to v0.1.5

Signed-off-by: George MacRorie <[email protected]>

* fix(cloud): handle context canceled healthy shutdown

Signed-off-by: George MacRorie <[email protected]>

* chore: check for existing instance in cloud (#3062)

* chore: check for existing instance in cloud

* chore: close body

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>

* feat: add cloud audit sink (#3058)

* feat: add cloud audit sink

* chore: cant enforce auth always for cloud

Signed-off-by: Mark Phelps <[email protected]>

* feat: make cloud experimental

* chore: fix schema

* chore: try to fix tests

Signed-off-by: Mark Phelps <[email protected]>

* chore: fmt audit payload

Signed-off-by: Mark Phelps <[email protected]>

* chore: basic cloud audit event test

Signed-off-by: Mark Phelps <[email protected]>

* chore: telemetry test

Signed-off-by: Mark Phelps <[email protected]>

* chore: change serve command desc

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>

* chore: upgrade reverst

Signed-off-by: Mark Phelps <[email protected]>

---------

Signed-off-by: Mark Phelps <[email protected]>
Signed-off-by: George MacRorie <[email protected]>
Co-authored-by: George MacRorie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants