Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change OpCostMetrics.memory to be a nonnegative_int #1586

Merged
merged 3 commits into from
Jan 21, 2025

Conversation

victorli2002
Copy link
Collaborator

@victorli2002 victorli2002 commented Jan 21, 2025

Description of changes:

  • Change OpCostMetrics.memory to be a nonnegative_int
  • Add nonnegative_int + nonnegative_int addition operator

Related Issues:

Linked Issues:

  • Issue #

Issues closed by this PR:


This change is Reviewable

@victorli2002 victorli2002 requested review from wmdi and lockshaw January 21, 2025 21:29
Copy link
Collaborator

@lockshaw lockshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @wmdi)

@lockshaw lockshaw enabled auto-merge (squash) January 21, 2025 21:54
@lockshaw lockshaw merged commit 3ee5e48 into flexflow:master Jan 21, 2025
4 of 5 checks passed
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.47%. Comparing base (34f3848) to head (efc73f5).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1586   +/-   ##
=======================================
  Coverage   60.47%   60.47%           
=======================================
  Files         606      606           
  Lines       14723    14725    +2     
=======================================
+ Hits         8903     8905    +2     
  Misses       5820     5820           
Flag Coverage Δ
unittests 60.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...utils/src/utils/nonnegative_int/nonnegative_int.cc 96.66% <100.00%> (+0.11%) ⬆️

@victorli2002 victorli2002 deleted the issue-1584 branch January 22, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change OpCostMetrics.memory to be a nonnegative_int
2 participants