Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly attempts to fix #3736 (comment). The heavy enums (colors and icons) were imported in
types.py
, which might have been the cause.Also, Enum vs String comparisons are now possible, ex:
ft.Colors.AMBER == "amber"
Summary by Sourcery
Refactor enum handling to allow string comparison.
New Features:
Enhancements:
_set_enum_attr
method in favor of_set_attr
.