Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdk: expose flet command on flet-cli instead of flet #4632

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Dec 27, 2024

  • expose the flet command on flet-cli instead of flet

Description

I am trying to package the latest version of flet in nixpkgs and there is a cyclic dependency between flet and flet-cli.

The reason, as far as I know, is to basically only expose the flet command.

Why not only expose the flet binary on flet-cli?

Test Code

# Test code for the review of this PR

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I signed the CLA.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • I have made corresponding changes to the documentation (if applicable)

Screenshots

Additional details

Summary by Sourcery

Build:

  • Move the flet command from the flet package to the flet-cli package.

@FeodorFitsner
Copy link
Contributor

We need flet binary in flet package to handle cases when users do pip install flet instead of pip install flet[all], so when you do pip install flet and then run flet <command> it installs flet-cli and redirects the request to it. Do you know how to handle that issue better?

@lucasew
Copy link
Contributor Author

lucasew commented Jan 10, 2025

What about merging flet and flet-cli into one package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants