Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Flashbots Protect button #506

Merged
merged 5 commits into from
Jan 9, 2024
Merged

New Flashbots Protect button #506

merged 5 commits into from
Jan 9, 2024

Conversation

72L
Copy link
Contributor

@72L 72L commented Jan 5, 2024

image

Copy link

vercel bot commented Jan 5, 2024

@72L is attempting to deploy a commit to the Flashbots Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flashbots-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 0:28am

@sukoneck sukoneck marked this pull request as draft January 5, 2024 20:04
@sukoneck sukoneck changed the title [WIP] New Flashbots Protect button New Flashbots Protect button Jan 5, 2024
@sukoneck
Copy link
Contributor

sukoneck commented Jan 5, 2024

@72L fyi I converted this to draft PR and removed the "[WIP]". just mark it as ready when you want it reviewed.

@sketsdever
Copy link
Collaborator

Looks awesome!

2 nits, if possible

  1. Can we add a tiny "->" arrow (after either the first or second row of text) so it's clear to people that this will take them to an external page?
  2. Can the button be horizontally centered within the main document section? (Instead of aligned left)

@72L
Copy link
Contributor Author

72L commented Jan 6, 2024

Thanks @sketsdever and @sukoneck

Updated the button as requested:
image

@sukoneck - it's ready to be reviewed with the only caveat that the button's src URL is not final (I imagine you'll want protect.flashbots.xyz or something similar)

@sukoneck
Copy link
Contributor

sukoneck commented Jan 7, 2024

nice! I'll merge once we have that URL ready.

Copy link
Collaborator

@sketsdever sketsdever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@72L this is great! Thanks for making those updates. @sukoneck I'm approving the PR now, will let you just update the URL once it's ready and then merge this in.

@sukoneck sukoneck marked this pull request as ready for review January 9, 2024 00:27
@sukoneck sukoneck merged commit 6736419 into flashbots:main Jan 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants