Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.8.8 & 1.8.9 change log #4123

Merged
merged 2 commits into from
Nov 20, 2024
Merged

1.8.8 & 1.8.9 change log #4123

merged 2 commits into from
Nov 20, 2024

Conversation

DavideIadeluca
Copy link
Contributor

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title 1.8.8 & 1.8.9 changelog 1.8.8 & 1.8.9 change log Nov 20, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review November 20, 2024 16:00
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner November 20, 2024 16:00
imorland
imorland approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @DavideIadeluca 👑

@imorland imorland merged commit a94bf44 into flarum:1.x Nov 20, 2024
274 checks passed
@imorland imorland deleted the di/changelog branch November 20, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideIadeluca @imorland