[1.x] [extensibility] feat: allow DiscussionsSearchSource
to be extended
#4025
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
This splits
DiscussionsSearchSource
out so that it is possible to extend/customize the following:On
DiscussionsSearchSource
includes
- allow adding additional includes from the frontend.limit
- allow setting a different results limitqueryMutators
- allow adding additional gambits to the default query. ie, fromfof/best-answer
, we can now choose to exclude best answer results from the normal discussions results, as this extension adds it's own search source with best answer results.New
DiscussionsSearchItem
This handles how the elements are presented within the search dropdown. We can customize:
discussionTitle
- ie, for within a translation extension so that titles can be presented already translatedmostRelevantPostContent
- as aboveviewItems
- add/remove/modify elements of the view by dealing with anItemList
Reviewers should focus on:
Screenshot
QA
Necessity
Confirmed
composer test
).