feat: vanilla CSS color scheme changes #3996
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Changes proposed in this pull request:
Changes the LESS/CSS code to be able to switch color schemes using Vanilla CSS (browser level) rather than having to recompile all of the LESS code based on configuration values.
This also means the ability to easily have per-user color scheme preferences, so this PR also adds the ability to select a color scheme per user while checking the user system's color scheme preference as default.
This also removes the
@config-dark-mode
and@config-colored-header
less variables as they are no longer used and should no longer be used in extensions in 2.0.Instead one can do:
Additionally, this will allow easily adding high contrast color schemes and the like for a11y (accessibility).
Screenshot
Necessity
Confirmed
composer test
).Required changes: