Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extension bisect #3980

Merged
merged 6 commits into from
May 3, 2024
Merged

feat: extension bisect #3980

merged 6 commits into from
May 3, 2024

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 14, 2024

Fixes #0000

Changes proposed in this pull request:
https://discuss.flarum.org/d/32734-extension-bisect-utility

Screenshot
image
image
image
image
image
image
image
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 added this to the 2.0 milestone Apr 14, 2024
@SychO9 SychO9 self-assigned this Apr 14, 2024
@SychO9 SychO9 requested a review from a team as a code owner April 14, 2024 11:39
askvortsov1
askvortsov1 requested changes Apr 14, 2024
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a way to stop the bisect halfway through?

framework/core/js/src/admin/components/AdvancedPage.tsx Outdated Show resolved Hide resolved
framework/core/js/src/admin/components/AdvancedPage.tsx
<Button
className={classList('Button', { 'Button--warning': app.data.bisecting })}
onclick={() => app.modal.show(ExtensionBisect)}
disabled={app.data.maintenanceMode && app.data.maintenanceMode !== MaintenanceMode.LOW_MAINTENANCE}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish we had a way to show a "disabled tooltip"

framework/core/locale/core.yml Outdated Show resolved Hide resolved
framework/core/locale/core.yml Outdated Show resolved Hide resolved
framework/core/src/Extension/Bisect.php Show resolved Hide resolved
@SychO9
Copy link
Member Author

SychO9 commented Apr 16, 2024

image
image

@SychO9 SychO9 requested a review from askvortsov1 April 16, 2024 10:18
askvortsov1
askvortsov1 approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, very exciting!

Base automatically changed from sm/maintenance-modes to 2.x May 3, 2024 13:05
@SychO9 SychO9 force-pushed the sm/extension-bisect branch from 1486866 to 9320db2 Compare May 3, 2024 13:12
@SychO9 SychO9 merged commit b02f819 into 2.x May 3, 2024
25 of 29 checks passed
@SychO9 SychO9 deleted the sm/extension-bisect branch May 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees

@SychO9 SychO9

Labels
needs-documentation type/feature
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @askvortsov1 @StyleCIBot