Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(flags): add pagination to flags list #3931

Merged
merged 12 commits into from
Nov 23, 2023
Merged

perf(flags): add pagination to flags list #3931

merged 12 commits into from
Nov 23, 2023

Conversation

OrdinaryJellyfish
Copy link
Contributor

@OrdinaryJellyfish OrdinaryJellyfish commented Nov 22, 2023 •
edited
Loading

Fixes #3787

Changes proposed in this pull request:

  • Adds pagination to flags list

Reviewers should focus on:

  • If the pagination works properly
  • If flags are ordered properly

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@OrdinaryJellyfish OrdinaryJellyfish requested a review from a team as a code owner November 22, 2023 00:55
@OrdinaryJellyfish OrdinaryJellyfish changed the title Add pagination to flags list feat(flags): add pagination to flags list Nov 22, 2023
SychO9
SychO9 reviewed Nov 22, 2023
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! as a side not, you usually want to avoid committing anything in dist or dist-typings

extensions/flags/js/src/forum/components/FlagList.tsx Show resolved Hide resolved
extensions/flags/src/Api/Controller/ListFlagsController.php Outdated Show resolved Hide resolved
SychO9
SychO9 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@SychO9 SychO9 changed the title feat(flags): add pagination to flags list perf(flags): add pagination to flags list Nov 23, 2023
@SychO9 SychO9 added this to the 2.0 milestone Nov 23, 2023
@SychO9 SychO9 assigned SychO9 and OrdinaryJellyfish and unassigned SychO9 Nov 23, 2023
@SychO9 SychO9 merged commit 46357ee into 2.x Nov 23, 2023
@SychO9 SychO9 deleted the tk/flags-pagination branch November 23, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees

@OrdinaryJellyfish OrdinaryJellyfish

Labels
type/performance
Projects
None yet
Milestone
2.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

flarum/flags should use pagination
2 participants
@OrdinaryJellyfish @SychO9