Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve emoji autocomplete #3923

Merged
merged 3 commits into from
Nov 11, 2023
Merged

feat: improve emoji autocomplete #3923

merged 3 commits into from
Nov 11, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Nov 3, 2023

Changes proposed in this pull request:

  • The current emoji autocomplete opens up by default by listing the first items on the emoji map from the cdn.
  • This PR make it so that the common smileys are listed by default.
  • This PR also improves the emoji autocomplete UX.

Before
image

After
image
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from a team as a code owner November 3, 2023 17:19
@SychO9 SychO9 added this to the 2.0 milestone Nov 3, 2023
@SychO9 SychO9 added type/feature javascript Pull requests that update Javascript code labels Nov 3, 2023
@SychO9 SychO9 self-assigned this Nov 3, 2023
@dsevillamartin
Copy link
Member

Could it be made so the name of the currently selected icon shows up in either placeholder or a tooltip? That way the name can be learned, as otherwise one would need to guess or keep selecting from the autocomplete every time. I see the alt attribute on the image, not sure if anything else would be better or helpful. Just a thought.

Otherwise, I like the changes! 👍

@SychO9
Copy link
Member Author

SychO9 commented Nov 5, 2023

@dsevillamartin it also has tooltips if that's you mean

image

@dsevillamartin
Copy link
Member

@SychO9 Oh, I did not see the code. Forgot how tooltips worked nowadays for a sec. 👍

@imorland
Copy link
Member

@SychO9 if you can take care of the conflict, this is ready to merge :)

@SychO9 SychO9 merged commit 1c0e093 into 2.x Nov 11, 2023
@SychO9 SychO9 deleted the sm/emoji-autocomplete branch November 11, 2023 18:31
@orschiro
Copy link

orschiro commented Dec 8, 2024

Quick question to this. When will this improvement be available?

Can anyone give me a rough date estimate?

I am wondering because this merge has been completed in Nov 23, and we are now in almost 2025.

Thanks!

@SychO9
Copy link
Member Author

SychO9 commented Dec 8, 2024

It's part of 2.0, so when the stable release of 2.0 is ready. We can't know when that will be.

@orschiro
Copy link

orschiro commented Dec 8, 2024 via email

@SychO9
Copy link
Member Author

SychO9 commented Dec 8, 2024

Hopefully months

@orschiro
Copy link

orschiro commented Dec 8, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants