Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle deprecations from 1.x #3909

Merged
merged 27 commits into from
Nov 10, 2023
Merged

chore: handle deprecations from 1.x #3909

merged 27 commits into from
Nov 10, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Oct 25, 2023

Changes proposed in this pull request:
Deals with what was deprecated from 1.x to clean up the codebase.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 added type/cleanup breaking-changes javascript Pull requests that update Javascript code labels Oct 25, 2023
@SychO9 SychO9 added this to the 2.0 milestone Oct 25, 2023
@SychO9 SychO9 requested a review from a team as a code owner October 25, 2023 16:39
@imorland imorland merged commit e2281a2 into 2.x Nov 10, 2023
22 checks passed
@imorland imorland deleted the sm/deprecations branch November 10, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-changes javascript Pull requests that update Javascript code type/cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants