Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link-checking workflow for docs #36

Conversation

aljazs-flare
Copy link
Collaborator

Internal Jira ticket id: FLR-69

Copy link
Contributor

@segfaultxavi segfaultxavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm afraid this solution does not work. You can see this PR is already failing the link check.

I can see at least two problems:

  • We use a markdown extension that automatically searches for files when they don't have a path. So, for example, ./file.md will look for the file in the same folder, but file.md will trigger this extension, locate the file anywhere in the tree and produce the correct link.
  • We use another markdown extension that allows us to create anchors, but the link checker does not recognize them.

I don't think any link checker that parses the md files will be able to fix this. Maybe there are solutions that parse the generated HTML files instead?

@aljazs-flare
Copy link
Collaborator Author

  • We use a markdown extension that automatically searches for files when they don't have a path. So, for example, ./file.md will look for the file in the same folder, but file.md will trigger this extension, locate the file anywhere in the tree and produce the correct link.

from my point of view this is sort of a hack. Just use relative paths from the get-go. I can include the patch for this in this MR.

  • We use another markdown extension that allows us to create anchors, but the link checker does not recognize them.

Anchors are fully supported by markdown. Is this extension really needed?

I don't think any link checker that parses the md files will be able to fix this. Maybe there are solutions that parse the generated HTML files instead?

I think that we should be validating the source files, not artifacts (generated HTML files).

aljazs-flare added a commit to aljazs-flare/docs that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants