-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/initial code #1
base: main
Are you sure you want to change the base?
Conversation
I wonder if this would be the place to handle the caching headers @ChasNelson1990 ? Ideally we want to be able to set them by file extension I think, looks like there's some overlap with this? |
@cooper667 I do not understand, could you explain please? |
I will fix after the reviews! |
Not a problem for this PR! It's more just me wondering whether the stuff im going to work on belongs in this extension. It's not quite security but it does involve changing the headers so may make sense logically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Toavina, thanks for getting this together. Good progress. There are few things concerning me slightly, and af ew other hints and tips around writing good CKAN code. Hopefully it is helpful!
Description
Initial code for this new extension.
Features:
Added tests for them.
The values on the picture are changed in order to test if the variables are read.
![image](https://private-user-images.githubusercontent.com/15812707/409044123-0ed1ff72-0cb1-4b36-a2d3-2453d4c0ff41.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzODk2NzcsIm5iZiI6MTczOTM4OTM3NywicGF0aCI6Ii8xNTgxMjcwNy80MDkwNDQxMjMtMGVkMWZmNzItMGNiMS00YjM2LWEyZDMtMjQ1M2Q0YzBmZjQxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDE5NDI1N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIxNmVjMGUzOTFjMjJhY2E3NzFhNDE2MTBmNTU2NmJhOTllNDJjNDI5Mzk5YTlhZTgxMzg2NmRiN2Q5NmQ5NjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ui3_02O5YHMvhl6U4NnS-SieiXEmY5lZNWK_6OrZ57g)
Relates https://github.com/fjelltopp/who-afro-ckan/pull/622
Relates https://github.com/fjelltopp/fjelltopp-infrastructure/pull/349
Closes https://github.com/fjelltopp/who-afro-ckan/issues/609
Closes https://github.com/fjelltopp/who-afro-ckan/issues/612
Checklist
Put an
x
in the boxes that apply to this pull request (you can also fill these out after opening the pull request).You may not need to check all boxes.