-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Standard Updates #13
Conversation
search_order: [ 'spark_utils', 'dbt_utils' ] | ||
public_models: [ | ||
"servicenow__user_enhanced", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this type of data would work. I've tested it against data that looks like it's on the Slab page.
It should look like this:
public_models:
servicenow__user_enhanced
servicenow__change_request_enhanced
servicenow__user_aggregated
servicenow__problem_enhanced
servicenow__activity_summary
servicenow__task_enhanced
servicenow__incident_enhanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @fivetran-markoteodorovic we modeled these public_models sections off of @FedorSafronov PR here.
My understanding is that these should be in a list format. The suggested yml format doesn't represent a list, but the suggested changes in this PR do as well as the following format:
public_models:
- servicenow__user_enhanced
- servicenow__change_request_enhanced
- servicenow__user_aggregated
- servicenow__problem_enhanced
- servicenow__activity_summary
- servicenow__task_enhanced
- servicenow__incident_enhanced
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fivetran-markoteodorovic I'm sure that a "bulleted" list as @fivetran-joemarkiewicz wrote it will produce an array and also a json-like notation (property: ['item1', 'item2']
will also produce an array). However, I'm not sure about the notation you mentioned. It may produce a list as well, but I'm not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, maybe all of theme could be parsed. If Fedors changes passed tests then this will too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This pull request was created automatically 🎉:
.github/
files have been properly updated (templates are updated and auto releaser is included).quickstart/quickstart.yml
file aspublic_models
(only for transform repos)**model
to**table**
(only for transform repos)