Merge pull request #2 from fivetran/review/jm-final

review/jm-final

.quickstart/quickstart.yml

@@ -1,7 +1,7 @@
 database_key: servicenow_database
 schema_key: servicenow_schema
 
-dbt_versions: ">=1.3.0" "<2.0.0"
+dbt_versions: ">=1.3.0 <2.0.0"
 
 destination_configurations:
   databricks:

CHANGELOG.md

@@ -12,7 +12,7 @@ The main focus of the package is to transform the core object tables into analyt
     - Adds column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
     - Generates a comprehensive data dictionary of your ServiceNow data through the [dbt docs site](https://fivetran.github.io/dbt_servicenow/).
 
-- The output models are focused around task Management. 
+  - The output models are focused around task Management. 
     - Summarizes task, problem, change, incident, and change request data by varying grains including last updated day, status, priority, impact, and urgency.
     - Enhances each task record with additional information about its associated problem, incident, or change request. Finally, it contains user information for who opened, started, updated, reported, fixed, closed, requested, reported, or confirmed the task.
 

README.md

@@ -20,13 +20,13 @@ This package models ServiceNow data from [Fivetran's connector](https://fivetran
 The main focus of the package is to transform the core object tables into analytics-ready models, including:
 <!--section="servicenow_model"-->
   - Materializes [ServiceNow staging and output models](https://fivetran.github.io/dbt_servicenow/#!/overview/servicenow/models/?g_v=1) which leverage data in the format described by [this ERD](https://fivetran.com/docs/applications/servicenow/#schemainformation). 
-  - The output models are focused around task Management. 
-    - Summarizes task, problem, change, incident, and change request data by varying grains including last updated day, status, priority, impact, and urgency.
-    - Enhances each task record with additional information about its associated problem, incident, or change request. Finally, it contains user information for who opened, started, updated, reported, fixed, closed, requested, reported, or confirmed the task.
   - The staging tables clean, test, and prepare your ServiceNow data from [Fivetran's connector](https://fivetran.com/docs/applications/servicenow) for analysis by doing the following:
     - Renames fields for consistency and standardization. For example, primary keys `sys_id` are renamed to `<table_name>_id`.
     - Adds column-level testing where applicable. For example, all primary keys are tested for uniqueness and non-null values.
     - Generates a comprehensive data dictionary of your ServiceNow data through the [dbt docs site](https://fivetran.github.io/dbt_servicenow/).
+  - The output models are focused around task Management. 
+    - Summarizes task, problem, change, incident, and change request data by varying grains including last updated day, status, priority, impact, and urgency.
+    - Enhances each task record with additional information about its associated problem, incident, or change request. Finally, it contains user information for who opened, started, updated, reported, fixed, closed, requested, reported, or confirmed the task.
 
 The output models are focused around the task management feature of Service Now.
 
@@ -36,7 +36,7 @@ The following table provides a detailed list of all models materialized within t
 
 | **Model**                 | **Description**                                                                                                    |
 | ------------------------- | ------------------------------------------------------------------------------------------------------------------ |
-| [servicenow__activity_summary](https://fivetran.github.io/dbt_servicenow/#!/model/model.servicenow.servicenow__activity_summary)  | Each record represents aggregate task, problem, change, incident, and change request data by varying grains including status, priority, impact, and urgency.    |
+| [servicenow__activity_summary](https://fivetran.github.io/dbt_servicenow/#!/model/model.servicenow.servicenow__activity_summary)  | Each record represents aggregate task, problem, change, incident, and change request data by varying grains including update date, status, priority, impact, and urgency.    |
 | [servicenow__task_enhanced](https://fivetran.github.io/dbt_servicenow/#!/model/model.servicenow.servicenow__task_enhanced)  | Each record represents a task with additional information about its associated problem, incident, or change request. Additionally, it contains user information for who opened, started, updated, reported, fixed, closed, requested, reported, or confirmed the task.  |
 <!--section-end-->
 

models/docs.md

@@ -1507,7 +1507,7 @@ The associated change request with this task; the sys_id from the change request
 {% enddocs %}
 
 {% docs servicenow__activity_summary %}
-Each record represents aggregate task, problem, change, incident, and change request data by varying grains including status, priority, impact, and urgency. 
+Each record represents aggregate task, problem, change, incident, and change request data by varying grains including update date, status, priority, impact, and urgency. 
 {% enddocs %}
 
 {% docs total_incidents_caused_by_problem %}
@@ -1724,4 +1724,12 @@ Name of the relevant business service.
 
 {% docs task_updated_date %}
 The day the task last got updated.
+{% enddocs %}
+
+{% docs unverified %}
+Boolean indicating if the change task is unverified.
+{% enddocs %}
+
+{% docs monitor %}
+Monitor in relation to the cmdb_ci_service.
 {% enddocs %}

models/staging/stg_servicenow.yml

@@ -1122,12 +1122,6 @@ models:
       - name: change_request_start_date
         description: '{{ doc("change_request_start_date") }}'
 
-      - name: std_change_producer_version_link
-        description: '{{ doc("std_change_producer_version_link") }}'
-
-      - name: std_change_producer_version_value
-        description: '{{ doc("std_change_producer_version_value") }}'
-
       - name: change_request_created_at
         description: '{{ doc("created_at") }}'
 
@@ -1152,17 +1146,15 @@ models:
     tests:
       - dbt_utils.unique_combination_of_columns:
           combination_of_columns:
-            - problem_task_id
+            - core_company_id
             - source_relation
     columns:
-      - name: problem_task_id
+      - name: core_company_id
         description: '{{ doc("sys_id") }}'
         tests:
           - not_null
       - name: source_relation
         description: '{{ doc("source_relation") }}'
-      - name: core_company_id
-        description: '{{ doc("sys_id") }}'
       - name: company_city
         description: '{{ doc("city") }}'
       - name: company_country
@@ -1287,6 +1279,10 @@ models:
         description: '{{ doc("vendor_link") }}'
       - name: vendor_value
         description: '{{ doc("vendor_value") }}'
+      - name: source_relation
+        description: '{{ doc("source_relation") }}'
+      - name: unverified
+        description: '{{ doc("unverified") }}'
 
   - name: stg_servicenow__cmdb_ci_service
     description: '{{ doc("stg_servicenow__cmdb_ci_service") }}'
@@ -1378,6 +1374,14 @@ models:
         description: '{{ doc("vendor_link") }}'
       - name: vendor_value
         description: '{{ doc("vendor_value") }}'
+      - name: source_relation
+        description: '{{ doc("source_relation") }}'
+      - name: cost_center_link
+        description: '{{ doc("cost_center_link") }}'
+      - name: cost_center_value
+        description: '{{ doc("cost_center_value") }}'
+      - name: monitor
+        description: '{{ doc("monitor") }}'
 
   - name: stg_servicenow__sys_user_group
     description: '{{ doc("stg_servicenow__sys_user_group") }}'
@@ -1461,7 +1465,8 @@ models:
       - name: sys_user_group_updated_at
         description: '{{ doc("sys_updated_on") }}'
 
-      - name: sys_user_group_type
+      - name: type
         description: '{{ doc("type") }}'
 
-
+      - name: source_relation
+        description: '{{ doc("source_relation") }}'