fix: tweak optional fields mainly for qualifications

Signed-off-by: Alexander Trost <[email protected]>
fivenet-app · Aug 17, 2024 · 4079215 · 4079215
1 parent cb6b5ca
commit 4079215
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/app/components/centrum/dispatches/DispatchCreateOrUpdateSlideover.vue b/app/components/centrum/dispatches/DispatchCreateOrUpdateSlideover.vue
@@ -20,7 +20,7 @@ const { location: storeLocation } = storeToRefs(livemapStore);
 
 const schema = z.object({
     message: z.string().min(3).max(255),
-    description: z.union([z.string().min(6).max(512), z.string().length(0).optional()]),
+    description: z.union([z.string().min(3).max(512), z.string().length(0).optional()]),
     anon: z.boolean(),
 });
 

diff --git a/app/components/qualifications/QualificationRequestUserModal.vue b/app/components/qualifications/QualificationRequestUserModal.vue
@@ -19,7 +19,7 @@ const { isOpen } = useModal();
 const notifications = useNotificatorStore();
 
 const schema = z.object({
-    userComment: z.string().min(3).max(255),
+    userComment: z.string().min(0).max(255),
 });
 
 type Schema = z.output<typeof schema>;

diff --git a/app/components/qualifications/tutor/QualificationRequestTutorModal.vue b/app/components/qualifications/tutor/QualificationRequestTutorModal.vue
@@ -32,7 +32,7 @@ const availableStatus = [
 
 const schema = z.object({
     status: z.nativeEnum(RequestStatus),
-    approverComment: z.string().min(3).max(255),
+    approverComment: z.string().max(255),
 });
 
 type Schema = z.output<typeof schema>;

diff --git a/app/components/qualifications/tutor/QualificationResultTutorForm.vue b/app/components/qualifications/tutor/QualificationResultTutorForm.vue
@@ -36,7 +36,7 @@ const selectedUser = ref<undefined | UserShort>(undefined);
 const schema = z.object({
     status: z.nativeEnum(ResultStatus),
     score: z.coerce.number().min(0).max(1000),
-    summary: z.string().min(3).max(255),
+    summary: z.string().max(255),
 });
 
 type Schema = z.output<typeof schema>;

diff --git a/proto/resources/users/users.proto b/proto/resources/users/users.proto
@@ -99,8 +99,8 @@ message UserActivity {
     min_len: 1,
     max_len: 64
   }]; // @gotags: alias:"fivenet_user_activity.key"
-  string old_value = 7 [(validate.rules).string.max_len = 256]; // @gotags: alias:"fivenet_user_activity.old_value"
-  string new_value = 8 [(validate.rules).string.max_len = 256]; // @gotags: alias:"fivenet_user_activity.new_value"
+  string old_value = 7 [(validate.rules).string.max_len = 255]; // @gotags: alias:"fivenet_user_activity.old_value"
+  string new_value = 8 [(validate.rules).string.max_len = 255]; // @gotags: alias:"fivenet_user_activity.new_value"
   // @sanitize
   string reason = 9 [(validate.rules).string.max_len = 255]; // @gotags: alias:"fivenet_user_activity.reason"
 }