forked from mit-pdos/xv6-riscv-fall19
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Esqueleto del TP2 #9
Open
sjdalessandro
wants to merge
55
commits into
tp2
Choose a base branch
from
tp2-new
base: tp2
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The defaults work fine now, since 3cbbeb0.
This is necessary because gcc may generate calls to memcmp, memset, memcpy, and memmove when compiling with -nostdlib.
its system calls), since we will not ask students to do the mount lab.
El parámetro terminate_match permite indicar a los tests las condiciones en las que se debería abortar el test: por ejemplo, una llamada a panic(). Con esto, se consigue no tener que tener que esperar al timeout si ello sucede. En el commit se incluye: - una expresión regular específica para alloctest - una expresión regular específica para usertests, definida en gradelib.py para poder ser usada en futuros labs Nota: la llamada a re.match() en gradelib se cambia a re.search() para evitar tener que especificar ".*" innecesariamente; y se añade el flag re.MULTILINE para aquellos matchers con anclaje.
This reverts commit 9eb5f31.
See: 6ff9f94 ("Perhaps a helpful hint when a student sees a kernel panic").
This reverts commit c8db843.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Si bien la base de este PR es una copia de la rama tp1, hacer merge de tp2-new sobre la solución del TP1 genera muchos conflictos, creo que es mejor dejar los TPs separados.
Lo probé con mi solución y pasa las pruebas.
This change is