Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for smaller laptops and ToC placement #79

Merged
merged 2 commits into from
Oct 10, 2018
Merged

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Oct 10, 2018

Fixes #77
Fixes #78

TOC Changes

The TOC is now above the text of the header section.

Width Changes

1368px wide
screenshot from 2018-10-10 16-01-16

1360px wide
screenshot from 2018-10-10 16-01-53

@samtstern
Copy link
Contributor Author

@rosariopfernandes what do you think?

Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast... 😅
Looks Great! 🎊

@samtstern samtstern merged commit 047223a into master Oct 10, 2018
@samtstern
Copy link
Contributor Author

@rosariopfernandes should be live in ~30m when the continuous build kicks in.

@thatfiredev
Copy link
Member

@samtstern I have my launcher bar on the left side of the screen, so this leaves ~1300px for the browser. Therefore I can't see the sidebar:
screenshot from 2018-10-11 09-14-41

But if I go fullscreen, or move the launcher bar to the bottom, the sidebar is visible:
screenshot from 2018-10-11 09-15-02

Maybe bring the width down to 1280px?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants