Read name from metadata as backup for gcs upload #4832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyjhuang
reviewed
Aug 4, 2022
Codecov Report
@@ Coverage Diff @@
## master #4832 +/- ##
==========================================
- Coverage 57.70% 57.69% -0.02%
==========================================
Files 287 287
Lines 18749 18753 +4
Branches 3701 3703 +2
==========================================
Hits 10819 10819
- Misses 7043 7047 +4
Partials 887 887
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tonyjhuang
reviewed
Aug 4, 2022
tonyjhuang
reviewed
Aug 4, 2022
tonyjhuang
reviewed
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses metadata.name as a backup to query.name in gcs uploads, this makes the storage emulator compliant with gcs api spec, fixes #3953
Scenarios Tested
Tested via the python gcs sdk and also by adding two new integration tests here.