Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTC-15321 - Use setDisplayMediaRequestHandler instead #2266

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

axeleriksson147
Copy link
Contributor

@axeleriksson147 axeleriksson147 commented Jan 20, 2025

https://perzoinc.atlassian.net/browse/RTC-15321

https://www.electronjs.org/docs/latest/api/desktop-capturer - In their documentation they're implementing screen sharing with setDisplayMediaRequestHandler. Electron the injects itself into the native navigator.mediaDevices.getDisplayMedia and returns whatever we set in the callback. Trying this solution instead of sending commands from the client and then processing them and returning the stream. This is because we've had issues with getting the sources and the screen picker showing up.

Guesses what could've made our SDA screensharing more unstable:

  • The desktopCapturer.getSources API is now only available in the main process. This has been changed in order to improve the default security of Electron apps.

@axeleriksson147 axeleriksson147 force-pushed the axeleriksson/RTC-15321-screen-share-issue branch from 2a6a51f to b7c4202 Compare January 20, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant