SDA-4636 Fix for missing screen share indicator frame #2185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at fixing missing screen share indicator frame while sharing screen by providing screen bounds rather than screen id to screen-sharing frame helper.
Context:
With v1.4.13, screen sharing frame is displayed on a given screen by providing id of that screen.
On screen-sharing frame helper side, we were getting all screens, getting the id (computed on the fly by hashing monitor device name) and comparing this hash with id of the screen where we need to display the frame.
However, chromium has updated the way a screen ID is being computed, moving from a hash of monitor device name sZDevice to a derivation of adapter and adapter ID for a given monitor: https://chromium-review.googlesource.com/c/chromium/src/+/5362362
Details of id creation available here: https://chromium-review.googlesource.com/c/chromium/src/+/5362362/25/ui/display/win/display_info.cc
This change made screen sharing frame not usable anymore if we provide a screen id.
It is still possible to rebuild screen ids on helper side same as Chromium does but this approach isn't future-proof: any change on Chromium side would break screen-sharing frame.
With v1.5.0 of screen-sharing frame helper, we are now able to display the frame on a given screen by providing its bounds.