Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDA-4636 Fix for missing screen share indicator frame #2185

Merged
merged 5 commits into from
Aug 27, 2024

Conversation

sbenmoussati
Copy link
Contributor

Description

This PR aims at fixing missing screen share indicator frame while sharing screen by providing screen bounds rather than screen id to screen-sharing frame helper.

Context:

With v1.4.13, screen sharing frame is displayed on a given screen by providing id of that screen.

On screen-sharing frame helper side, we were getting all screens, getting the id (computed on the fly by hashing monitor device name) and comparing this hash with id of the screen where we need to display the frame.

However, chromium has updated the way a screen ID is being computed, moving from a hash of monitor device name sZDevice to a derivation of adapter and adapter ID for a given monitor: https://chromium-review.googlesource.com/c/chromium/src/+/5362362

Details of id creation available here: https://chromium-review.googlesource.com/c/chromium/src/+/5362362/25/ui/display/win/display_info.cc

This change made screen sharing frame not usable anymore if we provide a screen id.

It is still possible to rebuild screen ids on helper side same as Chromium does but this approach isn't future-proof: any change on Chromium side would break screen-sharing frame.

With v1.5.0 of screen-sharing frame helper, we are now able to display the frame on a given screen by providing its bounds.

Copy link

linux-foundation-easycla bot commented Aug 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@sbenmoussati sbenmoussati merged commit fa515ac into finos:main Aug 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants