SDA-4514: NSIS Migration #2142
Merged
SDA-4514: NSIS Migration #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NguyenTranHoangSym
force-pushed
the
SDA-4514
branch
from
e9dea93 to
fd78cc5
Compare
NguyenTranHoangSym
force-pushed
the
SDA-4514
branch
from
fd78cc5 to
daf93c2
Compare
| push latestAutoUpdateChannelEnabled | ||
| call SearchAndReplace | ||
| FunctionEnd | ||
|
|
||
| !macro copySystemGlobalConfig |
There was a problem hiding this comment.
This logic also needs to be applied for per user install
There was a problem hiding this comment.
I added the logic to per user
sbenmoussati
requested changes
May 13, 2024
build/installer.nsh
Outdated
| @@ -56,6 +244,12 @@ FunctionEnd | |||
| !insertmacro UAC_RunElevated | |||
| Quit | |||
| ${endif} | |||
| call updateConfigIsPodUrlEditable | |||
| call updateConfigForceAutoUpdate | |||
There was a problem hiding this comment.
Yep indentation I dont have any format available
build/installer.nsh
Outdated
| @@ -56,6 +244,12 @@ FunctionEnd | |||
| !insertmacro UAC_RunElevated | |||
| Quit | |||
| ${endif} | |||
| call updateConfigIsPodUrlEditable | |||
There was a problem hiding this comment.
Why do we update config file for global install only?
NguyenTranHoangSym
force-pushed
the
SDA-4514
branch
from
daf93c2 to
4c79a66
Compare
KiranNiranjan
approved these changes
May 16, 2024
build/installer.nsh
Outdated
Comment on lines
152
to
161
| #FileOpen $8 "E:\Projects\NSIS\text.txt" w | ||
| #FileWrite $8 "$0$\r$\n" | ||
| #FileWrite $8 "$1$\r$\n" | ||
| #FileWrite $8 "$4$\r$\n" | ||
| #FileClose $8 | ||
|
|
||
| #LogText $0 | ||
| #DetailPrint $0 | ||
| #DetailPrint $1 | ||
| #DetailPrint $4 |
build/installer.nsh
Outdated
Comment on lines
115
to
118
| #FileWrite $8 "At done" | ||
| #FileWrite $8 "$4$\r$\n" | ||
| #FileWrite $8 "At done" | ||
| #FileWrite $8 "$R4$\r$\n" |
build/installer.nsh
Outdated
| @@ -44,6 +242,12 @@ FunctionEnd | |||
| !macroend | |||
|
|
|||
| !macro perUserM | |||
| call updateConfigIsPodUrlEditable | |||
| call updateConfigForceAutoUpdate | |||
build/installer.nsh
Outdated
| !macroend | ||
|
|
||
| Function SearchAndReplace | ||
| ${If} $PerUser == "exists" |
There was a problem hiding this comment.
indent issue here too
build/installer.nsh
Outdated
| @@ -44,6 +242,12 @@ FunctionEnd | |||
| !macroend | |||
|
|
|||
| !macro perUserM | |||
| call updateConfigIsPodUrlEditable | |||
There was a problem hiding this comment.
I think it would be clearer if we have all call in one function which can be called in perUserM and allUserM macros
NguyenTranHoangSym
force-pushed
the
SDA-4514
branch
from
4c79a66 to
a16b38f
Compare
sbenmoussati
force-pushed
the
SDA-4514
branch
2 times, most recently
from
37684ad to
825c98b
Compare
sbenmoussati
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding new NSIS script for migration of config file from 23.1 upto day
this script will eliminate duplicated config