C2-25477: OpenFin joinSessionContextGroup update (#2312)

When calling the exposed `joinSessionContextGroup`, it fails. This is probably because we try to return an object containing functions.
finos · Feb 26, 2025 · 8231068 · 8231068
1 parent c9007c2
commit 8231068
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/spec/openfinHandler.spec.ts b/spec/openfinHandler.spec.ts
@@ -197,15 +197,17 @@ describe('Openfin', () => {
 
   it('should join a session context group', async () => {
     const connectSyncMock = await connectMock.Interop.connectSync();
-    const joinSessionContextGroupSpy = jest.spyOn(
-      connectSyncMock,
-      'joinSessionContextGroup',
-    );
+    const joinSessionContextGroupSpy = jest
+      .spyOn(connectSyncMock, 'joinSessionContextGroup')
+      .mockResolvedValue({
+        id: 'createdId',
+      });
 
     await openfinHandler.connect();
-    await openfinHandler.joinSessionContextGroup('contextGroupId');
+    const id = await openfinHandler.joinSessionContextGroup('contextGroupId');
 
     expect(joinSessionContextGroupSpy).toHaveBeenCalledTimes(1);
+    expect(id).toEqual('createdId');
   });
 
   it('should return all context groups', async () => {

diff --git a/src/app/openfin-handler.ts b/src/app/openfin-handler.ts
@@ -133,7 +133,9 @@ export class OpenfinHandler {
    * Joins or create a context group that does not persist between runs and aren't present on snapshots.
    */
   public async joinSessionContextGroup(contextGroupId: string) {
-    return this.interopClient?.joinSessionContextGroup(contextGroupId);
+    return this.interopClient
+      ?.joinSessionContextGroup(contextGroupId)
+      .then(({ id }) => id);
   }
 
   /**