Skip to content

Commit

Permalink
SDA-4604 Bring to the front feature fix by calling show method (#2174)
Browse files Browse the repository at this point in the history
* SDA-4604 Bring to the front feature fix by calling show method

* Upgrade [email protected]
  • Loading branch information
sbenmoussati authored Jul 17, 2024
1 parent defcd1a commit 6d68185
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@
"builder-util-runtime": "^9.0.3",
"cross-env": "7.0.3",
"del": "3.0.0",
"electron": "31.2.0",
"electron": "31.2.1",
"electron-builder": "^24.13.2",
"electron-devtools-installer": "^3.2.0",
"electron-icon-maker": "0.0.5",
Expand Down
2 changes: 1 addition & 1 deletion spec/mainApiHandler.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ describe('main api handler', () => {
reason: 'notification',
windowName: 'notification',
};
const expectedValue = ['notification', false];
const expectedValue = ['notification'];
ipcMain.send(apiName.symphonyApi, value);
expect(spy).toBeCalledWith(...expectedValue);
});
Expand Down
2 changes: 1 addition & 1 deletion src/app/main-api-handler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ ipcMain.on(
if (typeof arg.reason === 'string' && arg.reason === 'notification') {
const { bringToFront } = config.getConfigFields(['bringToFront']);
if (bringToFront === CloudConfigDataTypes.ENABLED) {
activate(arg.windowName, false);
activate(arg.windowName);
}
}
break;
Expand Down

0 comments on commit 6d68185

Please sign in to comment.