fix: check decode error

[hunjixin]

No description provided.

[magik6k]

If we want to drop the connection, we should just call c.conn.Close and return.

[hunjixin]

if ignore this error. a request may send to to unstable connection, but never get a response

1. got decode error and tryReconnect. (inflight was removed) but not success
2. a request send before tryReconnect success(conn not change to new one), send can success because the network was not comlete unreachable
3. tryReconnect success, and change a new conn, but the request in step 2 will never get response
4. client request get stuck for ever

[Fatman13]

bump

[rjan90]

Hey! 👋

As part of our cleanup to kick off the year, I'm reviewing all open non-draft pull requests. Could you please do one of the following for your PR?

1. Close it: If it's no longer needed.
2. Mark as Draft: If it needs more work, and add the next steps.
3. Ready for Review: If it's good to go, let me know, and I'll assign a reviewer.

If there's no response in a week, I'll assume it's option 1 and close the PR. If you have any questions, just let me know.

Thanks for your help in keeping things organized, and I appreciate your contributions!

[rvagg]

This is quite out of date now, the current code handles the error with a log and moves on:

go-jsonrpc/websocket.go

Lines 691 to 696 in 9a16432

	if err := json.Unmarshal(buf, &frame); err != nil {
	log.Warnw("failed to unmarshal frame", "error", err)
	// todo send invalid request response
	continue
	}

Dropping the connection and returning an error is a reasonable thing to also do, but not necessary I think and also a bit difficult given that this is done in a separate goroutine now. I think this can just be closed and if @hunjixin wants to open a new PR that changes the current behaviour we can consider that separately.