Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent min width on not individually searchable table columns #15268

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

tanthammar
Copy link
Contributor

Description

This PR prevents min-w-48 and padding to be applied to columns that are not individually searchable.
It also prevents adding height to the search row if all individually searchable columns are hidden.

Visual changes

Before,

With visible searchable column
Observe, width of first and second column.
image

With searchable column toggled
Observe, height of search row.
image

After

With visible searchable column
Observe, width of first and second column.
image

With searchable column toggled
Observe, height of search row.
image

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the bug Something isn't working label Jan 7, 2025
@danharrin danharrin added this to the v3 milestone Jan 7, 2025
@danharrin danharrin merged commit 0602973 into filamentphp:3.x Jan 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants