fix: respect the model label defined in the resource class when using ExportAction 3.x #15237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borjajimnz
changed the title
borjajimnz
changed the title
|
I think this has been addressed in v4 as part of an architecture rethink, but this fix isn't correct as I don't think you can pass a custom model label just for this action anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in #13643, I'm not sure if this approach is the best, but it does fix the bug.
The thing is, the only way I found to get the model label is through the Livewire / table component. Is there another way to do this?
Functional changes
composer cscommand.