Properly deal with generic bounds in codegen #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagacity
force-pushed
the
serializable-bounds
branch
from
beb1cb9 to
421d997
Compare
arendjr
reviewed
Jul 6, 2022
examples/example-protocol/src/assets/rust_plugin_test/expected_types.rs
Outdated
Show resolved
Hide resolved
arendjr
approved these changes
Jul 15, 2022
| // Ignore other bound types (lifetimes) for now | ||
| _ => true, | ||
| } | ||
| }) |
There was a problem hiding this comment.
I think I would have used partition() for filtering the bounds, and then applied the side-effects to the extracted bounds.
There was a problem hiding this comment.
Good tip, I don't think I was even aware of partition. Would have worked well here, indeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue mentioned in #88 where trait bounds were incorrectly suffixed with
: Serializableeven if that bound was already present. Additionally, it allows the use of other bounds whereas previously any additional bounds would causecollect_typesto be invoked incorrectly.