Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add origin kwarg to wrapper geom classes #213

Merged
merged 2 commits into from
Jan 16, 2025
Merged

feat: add origin kwarg to wrapper geom classes #213

merged 2 commits into from
Jan 16, 2025

Conversation

mortenengen
Copy link
Member

I have added a kwarg to both the CircularGeometry and the RectangularGeometry to easily set the origin of the geometry to a point other than (0.0, 0.0).

@mortenengen mortenengen added the enhancement New feature or request label Jan 15, 2025
@mortenengen mortenengen changed the base branch from main to dev January 15, 2025 20:54
@mortenengen mortenengen marked this pull request as ready for review January 15, 2025 20:55
talledodiego
talledodiego approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@talledodiego talledodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks for having picked up this enhancement!

tests/test_geometry/test_circular.py Show resolved Hide resolved
tests/test_geometry/test_rectangular.py Show resolved Hide resolved
@mortenengen mortenengen merged commit 81b93c6 into dev Jan 16, 2025
5 checks passed
@mortenengen mortenengen deleted the add-origin-wrapper-geom branch January 16, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talledodiego talledodiego talledodiego approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
PR tracker
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mortenengen @talledodiego