forked from citynetwork/docs
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
build: Post pull request comments on build check failure
Without this change, when a PR results in a build failure, the onus is on the PR submitter to find the failed build, and the corresponding build log. That is somewhat tedious and not particularly intuituive. Instead, use a separate GitHub Action that posts a comment back to the PR thread, containing a direct link to the failed build log. This should hopefully make it easier for PR submitters to find out what exactly their submitted change breaks. References: https://github.com/quipper/comment-failure-action/ quipper/comment-failure-action#6
- Loading branch information
Showing
4 changed files
with
23 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
# Post a comment back on a PR thread, in case an associated workflow | ||
# failed. Note that comment-failure-action is a no-op in case the | ||
# workflow was not invoked in response to a PR. In other words, this | ||
# action only does creates a comments for workflows configured with | ||
# "on: pull_request". | ||
--- | ||
jobs: | ||
comment-failure: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: quipper/[email protected] | ||
|
||
name: comment | ||
|
||
'on': | ||
workflow_run: | ||
types: | ||
- completed | ||
workflows: | ||
- build |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ jobs: | |
- name: Deploy to gh-pages | ||
run: tox -e deploy-github | ||
|
||
name: Deploy | ||
name: deploy | ||
|
||
'on': | ||
push: | ||
|