Fix serial test #91
Closed
Fix serial test #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulkass
reviewed
Mar 28, 2020
drahnr
force-pushed
the
fix-serial-test
branch
3 times, most recently
from
6276a22 to
cc3c5e4
Compare
untested! Context creation still needs to be Arc'd
drahnr
force-pushed
the
fix-serial-test
branch
4 times, most recently
from
f469c55 to
791b396
Compare
Avoid creating multiple contexts
Assures that the right version from git is picked up, for the case we are not running from the workspace dir. This has to be done for all Cargo.toml files.
The setup and teardown methods should become a procmacro which avoids all the chore changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #71
Ref #90