Python 3 #3
Merged
Python 3 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to Python 3 as both dependencies (python-audio-tools, mutagen) now support it. The Python 2 support has been dropped in order to simplify the unicode handling.
Locally disable the PyLint warnings too-many-instance-attributes and too-many-arguments that are mainly caused by the transcoding hacks.
The warning warning W0142: 'Used * or ** magic' has been removed in PyLint 1.4.3 hence there is no reason to locally disable it any more.
The line "from multiprocessing import Pool" triggers the following harmless PyLint warning: E0611(no-name-in-module): No name 'Pool' in module 'multiprocessing' This commit locally disables the warning.
Create a SyncMusic class and create methods from most of the former functions. This allows getting rid of the globals by creating private attributes.
Create the destination directory when reading the settings. This improves usability as the user doesn't have to enter a destination directory that fully exists. If there are no input files or if program aborts due to any reason the created directory stays empty on the disk and is not deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.