Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(php): Implement dynamic snippets #5933

Merged
merged 14 commits into from
Feb 8, 2025
Merged

Conversation

amckinney
Copy link
Member

This implements the dynamic snippets for PHP. A couple of core features (e.g. discriminated unions) still need to be finished to resolve all of the cases, so a few cases are added to the allowedFailures set seed.yml.

Along the way, this also caught a couple of issues that are also resolved here:

  1. We don't require the user to construct an inlined request object if it's composed of entirely optional fields.
  2. We map a list of optional query parameters into an optional list of query parameters.
    • This is far more convenient for the user and was the intended use case.
    • For example, array<?string> -> ?array<string>

This also includes the integration with seed so that every snapshot will have a separate dynamic-snippets directory containing a variety of snippet examples. This ensures the snippet generator is valid for each test definition.

@amckinney amckinney merged commit df8d1b9 into main Feb 8, 2025
50 of 53 checks passed
@amckinney amckinney deleted the amckinney/php/snippets branch February 8, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants