Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): fix in-line Alias, base properties, and extended properties example generation. #5922

Merged
merged 17 commits into from
Feb 7, 2025
Merged

fix(cli): fix in-line Alias, base properties, and extended properties example generation. #5922

merged 17 commits into from
Feb 7, 2025

Conversation

eyw520
Copy link
Member

@eyw520 eyw520 commented Feb 7, 2025

Description

Help unblock dynamic snippets in testing.

Changes Made

  • Fix in-line Alias type example generation.
  • Fix missing properties for unions and objects.

Testing

  • Unit tests added/updated
  • Manual testing completed

@eyw520 eyw520 marked this pull request as ready for review February 7, 2025 15:46
@eyw520 eyw520 requested a review from dsinghvi as a code owner February 7, 2025 15:46
amckinney
amckinney approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@amckinney amckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👏

@amckinney amckinney merged commit d73e105 into main Feb 7, 2025
47 of 51 checks passed
@amckinney amckinney deleted the eden/fix-broken-example-generation branch February 7, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amckinney amckinney amckinney approved these changes

@dsinghvi dsinghvi Awaiting requested review from dsinghvi dsinghvi is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyw520 @amckinney @fern-support