chore(csharp): Misc improvements #5838
Merged
+20,637
−22,244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Call `.ConfigureAwait(false)` on Tasks - Use Enumerable<T>.Empty instead of creating a new empty list - Add PolySharp to test project and use C# 12 - Improve C# syntax - Remove redundant `#nullable enable` directives
Swimburger
changed the title
…ern-api/fern into niels/csharp/misc-improvements
Swimburger
changed the title
amckinney
approved these changes
Feb 3, 2025
| "enum_property": "{{KnownEnumValue2String}}" | ||
| } | ||
| """; | ||
| private const string JsonWithKnownEnum2 = $$""" |
There was a problem hiding this comment.
Is this string format preferred? I would have thought the previous nesting was better.
There was a problem hiding this comment.
This must be csharpier, the source template doesn't format it like this
I think test definitions changed which is uncovering some bugs in the C# generator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Miscellaneous improvement for the C# generator
.ConfigureAwait(false)on TasksEnumerable<T>.Emptyinstead of creating a new empty list#nullable enabledirectivesSystemTaskalias forSystem.Threading.Tasks.Taskto avoid conflict with potentially namedTaskresourcesTesting