Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csharp): Serialize headers and querystring params more reliably #5706

Merged
merged 7 commits into from
Jan 22, 2025

Conversation

Swimburger
Copy link
Member

@Swimburger Swimburger commented Jan 22, 2025

Description

Change serialization logic for headers and query string parameters:

  • Strings, enums, dates, times, and date times are serialized as before.
  • Booleans are now serialized as true and false instead of True and False.
  • Objects, lists, maps, dictionaries, undiscriminated, and discriminated unions are serialized to JSON.

Testing

  • Unit tests added/updated
  • Seed

Confirmed the output for customer asking is what they expected.

Copy link

github-actions bot commented Jan 22, 2025

@Swimburger Swimburger marked this pull request as ready for review January 22, 2025 06:48
@Swimburger Swimburger requested a review from dsinghvi as a code owner January 22, 2025 06:48
@Swimburger Swimburger merged commit 89b06f2 into main Jan 22, 2025
51 of 52 checks passed
@Swimburger Swimburger deleted the niels/csharp/serialize-headers-querystring-params branch January 22, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants