Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add Readme importer changelog, fix missing imported slugs & callout components. #5702

Merged
merged 5 commits into from
Jan 22, 2025

Conversation

eyw520
Copy link
Member

@eyw520 eyw520 commented Jan 22, 2025

Description

Resolved a bug where Callout components in Readme led to broken site scraping.

Changes Made

  • Correctly parse out Callout text when parsing Readme Callouts.
  • Better debug logging to catch errored pages during scraping.

Testing

  • Manual testing completed

@eyw520 eyw520 requested a review from dsinghvi as a code owner January 22, 2025 00:59
Copy link

github-actions bot commented Jan 22, 2025

@@ -23,5 +23,6 @@ generators/openapi/* @dsinghvi
# Specific rules for packages
packages/cli/* @amckinney
packages/cli/api-importers/* @eyw520
packages/cli/docs-importers/* @eyw520
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@eyw520 eyw520 merged commit 1dc859f into main Jan 22, 2025
52 checks passed
@eyw520 eyw520 deleted the eden/readme-importer-patch branch January 22, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants