feat(cli): merge generated snippets from IR into OpenApi v2 parser result #5628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsinghvi
reviewed
Jan 16, 2025
dsinghvi
reviewed
Jan 16, 2025
There was a problem hiding this comment.
@RohinBhargava how are you planning to add tests for this? I think it would be worth running all of the OpenAPI tests with this and snapshotting FdrLatest
RohinBhargava
changed the title
Unfortunately, we're running into the fdr import issue as previously with the snapshot tests. Have created a bunch of fixtures on platform side to address this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges SDK snippets generated by IR path into result of OpenApi v2 parser for cool renders!
Changes Made
Testing
Generated sdk snippets for customer spec