fix(go): Update default retry status codes (#5194)

fern-api · Nov 18, 2024 · 8345556 · 8345556
1 parent d69b2f2
commit 8345556
Show file tree

Hide file tree

Showing 98 changed files with 9 additions and 96 deletions.
diff --git a/fern/pages/changelogs/go-sdk/2024-11-18.mdx b/fern/pages/changelogs/go-sdk/2024-11-18.mdx
@@ -0,0 +1,3 @@
+## 0.31.3
+**`(fix):`** Updates the retrier to stop retrying on `409 Conflict` HTTP status codes by default.
+
diff --git a/generators/go/internal/generator/sdk/internal/retrier.go b/generators/go/internal/generator/sdk/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/auth/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/auth/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/basic/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/basic/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/bearer-token-name/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/bearer-token-name/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/bearer/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/bearer/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/bytes/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/bytes/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/client-options-core/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/client-options-core/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/client-options-filename/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/client-options-filename/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/cycle/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/cycle/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/default/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/default/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/docs/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/docs/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/download/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/download/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/empty/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/empty/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/environments-core/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/environments-core/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/environments/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/environments/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/error-discrimination/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/error-discrimination/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/error/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/error/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/headers/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/headers/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/mergent/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/mergent/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/multi-environments/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/multi-environments/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/optional-core/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/optional-core/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/optional-filename/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/optional-filename/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/optional-response/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/optional-response/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/packages/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/packages/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/path-and-query-params/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/path-and-query-params/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/path-params/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/path-params/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/platform-headers/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/platform-headers/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/pointer-core/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/pointer-core/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/pointer-filename/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/pointer-filename/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/...tors/go/internal/testdata/sdk/post-with-path-params-generics/fixtures/internal/retrier.go b/...tors/go/internal/testdata/sdk/post-with-path-params-generics/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/post-with-path-params/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/post-with-path-params/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/query-params-complex/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/query-params-complex/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/query-params-multiple/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/query-params-multiple/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/query-params/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/query-params/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/root/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/root/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/internal/testdata/sdk/upload/fixtures/internal/retrier.go b/generators/go/internal/testdata/sdk/upload/fixtures/internal/retrier.go
@@ -130,7 +130,6 @@ func (r *Retrier) run(
 func (r *Retrier) shouldRetry(response *http.Response) bool {
 	return response.StatusCode == http.StatusTooManyRequests ||
 		response.StatusCode == http.StatusRequestTimeout ||
-		response.StatusCode == http.StatusConflict ||
 		response.StatusCode >= http.StatusInternalServerError
 }
 

diff --git a/generators/go/sdk/versions.yml b/generators/go/sdk/versions.yml
@@ -1,3 +1,9 @@
+- version: 0.31.3
+  changelogEntry:
+    - type: fix
+      summary: >-
+        Updates the retrier to stop retrying on `409 Conflict` HTTP status codes by default.
+  irVersion: 53
 - version: 0.31.2
   changelogEntry:
     - type: internal

diff --git a/seed/go-sdk/alias/internal/retrier.go b/seed/go-sdk/alias/internal/retrier.go
diff --git a/seed/go-sdk/any-auth/internal/retrier.go b/seed/go-sdk/any-auth/internal/retrier.go
diff --git a/seed/go-sdk/api-wide-base-path/internal/retrier.go b/seed/go-sdk/api-wide-base-path/internal/retrier.go
diff --git a/seed/go-sdk/audiences/internal/retrier.go b/seed/go-sdk/audiences/internal/retrier.go
diff --git a/seed/go-sdk/auth-environment-variables/internal/retrier.go b/seed/go-sdk/auth-environment-variables/internal/retrier.go
diff --git a/seed/go-sdk/basic-auth-environment-variables/internal/retrier.go b/seed/go-sdk/basic-auth-environment-variables/internal/retrier.go
diff --git a/seed/go-sdk/basic-auth/internal/retrier.go b/seed/go-sdk/basic-auth/internal/retrier.go
diff --git a/seed/go-sdk/bearer-token-environment-variable/internal/retrier.go b/seed/go-sdk/bearer-token-environment-variable/internal/retrier.go
diff --git a/seed/go-sdk/bytes/internal/retrier.go b/seed/go-sdk/bytes/internal/retrier.go
diff --git a/seed/go-sdk/circular-references-advanced/internal/retrier.go b/seed/go-sdk/circular-references-advanced/internal/retrier.go
diff --git a/seed/go-sdk/circular-references/internal/retrier.go b/seed/go-sdk/circular-references/internal/retrier.go
diff --git a/seed/go-sdk/cross-package-type-names/internal/retrier.go b/seed/go-sdk/cross-package-type-names/internal/retrier.go
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		## 0.31.3
		`(fix):` Updates the retrier to stop retrying on `409 Conflict` HTTP status codes by default.