-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release new version v0.3.1 of kube #85
release new version v0.3.1 of kube #85
Conversation
just FYI, I am also working on a tool to auto-review the PRs (based on a similar tool we use for kubectl plugins). The tool will verify that the changes in PR are for version bumps only, and can auto-approve/merge the PR. We have been using this pattern quite successfully for Kubectl plugins for over 5 years now. |
It looks like one of the commits has not been signed thus stopping the merge. |
yeah, none of them are signed. it seems like the github api (atleast the one i am using) does not support signing of commits. should we reconsider "sign-commit" requirement for this repo? because this repo only has manifest data about the plugins, and not necessarily any plugin code, I am not sure if we need to be very strict about that. but also I am not an expert in this area. what do you think @endocrimes Edit: sorry, this is me @rajatjindal who wrote the above comment. and not the bot 🤣 |
I think I have a path forward, I will try to get this (add ability to sign commits) done this week. |
Thanks for picking this up @rajatjindal, let us know if we can help in anyway. |
Signed-off-by: Kate Goldenring <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
4f140c5
to
f13b6da
Compare
@rajatjindal @calebschoepp, for now, I just rebased and signed off on each commit to get us passing |
thank you Kate. |
hey team,
I am spin-plugin-release-bot, and I would like to open this PR to publish version
v0.3.1
ofkube
on behalf of @endocrimes.Thanks,
@rajatjindal