Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version v0.3.1 of kube #85

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

spin-plugin-release-bot
Copy link
Contributor

hey team,

I am spin-plugin-release-bot, and I would like to open this PR to publish version v0.3.1 of kube on behalf of @endocrimes.

Thanks,
@rajatjindal

@rajatjindal
Copy link
Contributor

just FYI, I am also working on a tool to auto-review the PRs (based on a similar tool we use for kubectl plugins). The tool will verify that the changes in PR are for version bumps only, and can auto-approve/merge the PR.

We have been using this pattern quite successfully for Kubectl plugins for over 5 years now.

@karthik2804
Copy link
Contributor

karthik2804 commented Nov 13, 2024

It looks like one of the commits has not been signed thus stopping the merge.

@spin-plugin-release-bot
Copy link
Contributor Author

spin-plugin-release-bot commented Nov 13, 2024

yeah, none of them are signed. it seems like the github api (atleast the one i am using) does not support signing of commits.

should we reconsider "sign-commit" requirement for this repo? because this repo only has manifest data about the plugins, and not necessarily any plugin code, I am not sure if we need to be very strict about that. but also I am not an expert in this area.

what do you think @endocrimes

Edit: sorry, this is me @rajatjindal who wrote the above comment. and not the bot 🤣

@rajatjindal
Copy link
Contributor

I think I have a path forward, I will try to get this (add ability to sign commits) done this week.

@calebschoepp
Copy link

Thanks for picking this up @rajatjindal, let us know if we can help in anyway.

@kate-goldenring
Copy link
Collaborator

@rajatjindal @calebschoepp, for now, I just rebased and signed off on each commit to get us passing

@kate-goldenring kate-goldenring merged commit 546dac7 into fermyon:main Nov 18, 2024
2 checks passed
@rajatjindal
Copy link
Contributor

thank you Kate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants