-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on ZipFiles.jl and EzXML.jl #280
Open
TimG1964
wants to merge
22
commits into
felipenoris:master
Choose a base branch
from
TimG1964:Remove-dependency-on-ZipFile
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Remove dependency on ZipFiles.jl and EzXML.jl #280
TimG1964
wants to merge
22
commits into
felipenoris:master
from
TimG1964:Remove-dependency-on-ZipFile
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove remaining dependency on ZipFile.jl
overloaded findall() and findfirst() functions and a single call to EzXMLunlnk().
function that uses the XML.jl API.
There are a couple of other things to point out:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows previous attempts and helpful feedback on Discourse here, and here. There was another thread, too, but I can't find it now. (EDIT Not a discourse thread but comments on a previous PR, here. I think I've followed all of @nhz2's advice in this PR.)
I've removed all dependence on both ZipFiles.jl (in favour of ZipArchives.jl) and EzXML.jl (in favour of XML.jl). I could not replace ZipFiles until after I had replaced EzXML, but EzXML was used ubiquitously throughout the XLSX package so replacing it was a comparatively big task.
Some important caveats:
I have relied on the heavy lifting done by @felipenoris throughout.
This PR passes all tests locally and works perfectly in my use case, which gives some confidence in making this PR. However, I think it will still need review by a competent person both for correctness and for efficiency. I haven't benchmarked, but it seems, subjectively, to be about the same speed as before.