Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gc calls #270

Closed
wants to merge 2 commits into from
Closed

remove gc calls #270

wants to merge 2 commits into from

Conversation

felipenoris
Copy link
Owner

@felipenoris felipenoris commented Sep 22, 2024

Related to #42, #173 and #252.

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (f4767c4) to head (9f86c8d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   95.02%   95.07%   +0.05%     
==========================================
  Files          15       15              
  Lines        2009     2010       +1     
==========================================
+ Hits         1909     1911       +2     
+ Misses        100       99       -1     
Flag Coverage Δ
95.07% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@felipenoris felipenoris deleted the fn/windows_gc branch September 22, 2024 03:26
@TimG1964
Copy link
Contributor

TimG1964 commented Sep 29, 2024

There is a similar gc call in Windows in write.jl at line 87. Is it safe to remove that one, too? See this question on Discourse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants