Skip to content

Commit

Permalink
Remove the gc call in write.jl (#271)
Browse files Browse the repository at this point in the history
This gc call was added in Windows only, apparently in response to issue #42.

The consequence was that `writexlsx()` was much slower, with 97% of time spent on gc (in my use case).

Deleting this line speeds up `writexlsx()` forty-fold and XLSX still passes all tests.

Not sure what, if any, downsides there might be in other use cases.
  • Loading branch information
TimG1964 authored Sep 29, 2024
1 parent 2d2d98b commit 39ffc15
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/write.jl
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ function writexlsx(output_source::Union{AbstractString, IO}, xf::XLSXFile; overw
print(xlsx, generate_sst_xml_string(get_sst(xf)))
end
end
# fix libuv issue on windows (#42)
@static Sys.iswindows() ? GC.gc() : nothing
nothing
end

Expand Down

0 comments on commit 39ffc15

Please sign in to comment.