Fix output retrieval during Direnv import #67
+57
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add settings option for configuring timeout - Handle direnv errors correctly - Read stdout of direnv completely right away as the process only then terminates
Chrisimx
force-pushed
the
fix-direnv-import
branch
from
4293d7e to
ee779b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my setup the IDE always hanged forever when importing a direnv. The reason for this was that
process.waitFor() != 0doesn't work anymore as direnv only terminates after its output has been read (but the direnv output seems correct). Therefore, this line waited forever as the stdout would only have been read after this.This PR changes the implementation to read the stdout first until the EOF and then waits for termination of the proccess with a configurable timeout, so that the IDE does not hang forever (as it does right now).
The built plugin is here (for anyone who wants to try it):
Direnv integration-0.2.10.zip
You can install it manually in the plugin settings after uninstalling the old version.
Tries to fix #11