Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance](*) introduce alert manager #909

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Conversation

cosven
Copy link
Member

@cosven cosven commented Feb 4, 2025

  • introduce alert manager
    • show_msg when there is a ConnectTimeout currently
  • show error message in search page

@coveralls
Copy link

coveralls commented Feb 4, 2025

Pull Request Test Coverage Report for Build 13138954848

Details

  • 40 of 82 (48.78%) changed or added relevant lines in 8 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 55.814%

Changes Missing Coverage Covered Lines Changed/Added Lines %
feeluown/gui/widgets/login.py 0 1 0.0%
feeluown/player/playlist.py 1 4 25.0%
feeluown/library/library.py 12 19 63.16%
feeluown/gui/components/search.py 0 14 0.0%
feeluown/alert.py 15 32 46.88%
Files with Coverage Reduction New Missed Lines %
feeluown/task.py 1 92.41%
feeluown/gui/components/search.py 2 21.67%
Totals Coverage Status
Change from base Build 13108953604: -0.04%
Covered Lines: 10234
Relevant Lines: 18336

💛 - Coveralls

@cosven cosven merged commit d8ee8dd into feeluown:master Feb 4, 2025
7 of 9 checks passed
@cosven cosven deleted the alert-manager branch February 4, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants